Fix schedule page bugs #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e timetable area, now properly resizes to fit; added a separator between the time column and day columns that is static while scrolling; added indication of the current day by brightening the background colour of timetable slots within the current days column to increase readability;
…osition set correctly, added documentation to all components interfaces and functions
…ments to hide overflowing content, fixed resizing functions to account for new positioning
… hover events to register with the timetable underneath, added pointer-events-auto to TimetableTask divs to re-enable hover events, disabled overscroll on timetable-barrier as it was causing foreground elements to desync with background
…unctions were not working properly likely due to a race condition when setting the scrollTop and scrollLeft properties
…nces of barrier in code with content for more clarity about the purpose of the timetable-content element
…rrecting position to be more clear as to why the correct is necessary, renamed Time-Labels to timetable-time-labels to follow naming convention of other elements, changed headers id from Day-Header to Day-header to follow naming convention of other elements, added background colour and z positioning to timetable-headers div to fix an issue where background could be seen through gaps between headers and added resizing logic for this component within resizeAndPositionTimetableHeaders, changed the zIndex of various components to display correctly
…ing parentElement for better clarity
…nd updated resizeAndPositionTimetableHeaders documentation to mention the resizing of the timetable-headers component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Change Form