[css mode] add caseInsensitive hint#6855
Open
Realetive wants to merge 2 commits intocodemirror:masterfrom
Open
[css mode] add caseInsensitive hint#6855Realetive wants to merge 2 commits intocodemirror:masterfrom
Realetive wants to merge 2 commits intocodemirror:masterfrom
Conversation
marijnh
reviewed
Dec 24, 2021
| function add(keywords) { | ||
| for (var name in keywords) | ||
| if (!word || name.lastIndexOf(word, 0) == 0) | ||
| result.push(name); |
Member
There was a problem hiding this comment.
This definitely won't work for pseudoClasses defined above. What is it intended to do?
Author
There was a problem hiding this comment.
CSS is not case-sensitive. The current solution doesn't work with properties and values that the user will camelCase (ex. optimizeSpeed instead of optimizespeed). I want to fix this. Do you have any idea how to solve the problem with pseudoClasses?
Member
There was a problem hiding this comment.
No I mean, given that keySet is only called with lower-case strings, what is the purpose of making the object values hold another copy of the string?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current PR allow to invoke CSS hint for property or value in any case: