feat: add Circuit-ID hash collision monitoring (#90)#104
Merged
Conversation
Add CheckCircuitIDCollision method that detects when a circuit-ID hash maps to a different MAC than the one being inserted. Document FNV-1a collision characteristics (birthday paradox probabilities at scale). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add bng_circuit_id_hash_collisions_total counter and bng_circuit_id_collision_rate gauge. The rate is computed from the DHCP server's insertion/collision counters during periodic metric collection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Check for hash collisions before inserting circuit-ID mappings in handleRequest. Track insertion/collision counts atomically and invoke an optional callback so the metrics layer can record each collision. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #90