Potential fix for code scanning alert no. 1: Code injection #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/codeharborhub/tutorial/security/code-scanning/1
To fix the problem, we should stop inserting
github.event.issue.bodydirectly into the shell script via GitHub expression syntax and instead pass it through an environment variable, then read that environment variable using normal shell variable expansion. This removes the opportunity for the GitHub expression engine to splice attacker-controlled text directly into the script’s source.The best minimal-change fix is:
env:section to theValidate Issue ContentandCheck for Security and Truststeps to mapISSUE_BODY: ${{ github.event.issue.body }}.run:block, replaceissue_body="${{ github.event.issue.body }}"withissue_body="$ISSUE_BODY".This preserves all existing logic (string checks on the issue body) while aligning with GitHub’s recommended safe pattern. No additional methods or external libraries are needed; only YAML changes within
.github/workflows/issue_creation_workflow.ymlin the two affected steps.Suggested fixes powered by Copilot Autofix. Review carefully before merging.