Potential fix for code scanning alert no. 2: Code injection #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/codeharborhub/dsa/security/code-scanning/2
In general, to fix this kind of problem in GitHub Actions you should avoid referencing untrusted
github.*values directly inside shell scripts via${{ ... }}. Instead, pass those values into the step as environment variables, and then read them using the shell’s native environment variable syntax (e.g.,$ISSUE_BODY). This ensures the Actions expression engine only substitutes values in a safe context and reduces the risk of subtle parsing or injection issues in the shell.For this specific workflow, the unsafe usage occurs where
issue_bodyis assigned using${{ github.event.issue.body }}in theValidate Issue Contentstep (line 37) and again in theCheck for Security and Truststep (line 45). The best fix without changing functionality is:env:section to each of these two steps, defining e.g.ISSUE_BODY: ${{ github.event.issue.body }}.run:script blocks, replaceissue_body="${{ github.event.issue.body }}"withissue_body="$ISSUE_BODY"(or just use$ISSUE_BODYdirectly in the conditions).This keeps the logic identical (still checking for disallowed phrases and for mentions of “security” and “trust”) while following GitHub’s recommended pattern. No new imports or external tools are needed; changes are confined to
.github/workflows/issue_creation_workflow.ymlin those two steps.Suggested fixes powered by Copilot Autofix. Review carefully before merging.