Fixed EVFEVENT target retrieval from command line#3096
Open
sebjulliand wants to merge 1 commit intomasterfrom
Open
Fixed EVFEVENT target retrieval from command line#3096sebjulliand wants to merge 1 commit intomasterfrom
EVFEVENT target retrieval from command line#3096sebjulliand wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Contributor
|
👋 A new build is available for this PR based on c128edd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes a small regression introduced by #2926 when the FILE target support was added.
This PR fixes a but that would make the
getObjectFromCommandreturns the source file as the target object for EVFEVENT lookup.The bug happens if the
SRCFILEparameter is found before the actual object name parameter, or if there is no object parameter - because the regular expression that looks up the object paramter will matchSRCFILE.Examples with the issue:
As a result, problems are not retrieved after the action has run as you see this in the output:
Instead of
Adding a leading whitespace in the regex to it matches the actual parameter fixes the problem.
How to test this PR
SRCFILEparameter appears before any other parameter in the command lineSRCFILEChecklist