Fixed editors being blank if reconnect setting is "never"#3089
Open
sebjulliand wants to merge 1 commit intomasterfrom
Open
Fixed editors being blank if reconnect setting is "never"#3089sebjulliand wants to merge 1 commit intomasterfrom
sebjulliand wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
sebjulliand
added
the
bug
Contributor
|
👋 A new build is available for this PR based on d401560. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Following up #3058
When the
Auto Reconnectsetting is set tonever, editors left opened would remain opened and blank.This PR fixes this so this editors are correctly closed on startup.
It also fix a crash that can happen when the setting is set to
askand the user closes the notification: the editor tab may show an error instead of being closed.How to test this PR
neveraskChecklist