fix: redirect logged-out users when clicking Follow on testimony#2063
Open
saschabuehrle wants to merge 1 commit intocodeforboston:mainfrom
Open
fix: redirect logged-out users when clicking Follow on testimony#2063saschabuehrle wants to merge 1 commit intocodeforboston:mainfrom
saschabuehrle wants to merge 1 commit intocodeforboston:mainfrom
Conversation
saschabuehrle
requested review from
Mephistic,
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Issue #2059 reports that logged-out users can click the Follow button on a testimony page, but nothing happens.
Fix
This PR updates
BaseFollowButtonto redirect unauthenticated users to the login page when they click follow/unfollow.router.push('/login?redirect=...')with the current pathThis makes the button behavior consistent with the rest of the app’s auth-protected flows.
Testing
YARN_IGNORE_ENGINES=1 yarn check-typesYARN_IGNORE_ENGINES=1 ./node_modules/.bin/eslint components/shared/FollowButton.tsxHappy to address any feedback.
Greetings, saschabuehrle