-
Notifications
You must be signed in to change notification settings - Fork 10
Use Is_disjoint optimization in Shadow Mode #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
+ Coverage 93.82% 93.83% +0.01%
==========================================
Files 1280 1282 +2
Lines 46120 46336 +216
Branches 1511 1527 +16
==========================================
+ Hits 43272 43480 +208
- Misses 2540 2547 +7
- Partials 308 309 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #538 will not alter performanceComparing Summary
Footnotes |
Address this issue:
https://linear.app/getsentry/project/report-merging-improvements-89f3063419db/overview
Primary Fix: Use the
is_disjointOptimization in Shadow ModeThe
Report.merge()method has a built-in optimization that wasn't being used:is_disjoint=True: Defers expensive line-by-line merging, just appends coverage recordsfinish_merge(): Performs actual merging in one pass at the endChanges:
In
libs/shared/shared/utils/merge.pydeduplicate_sessionsfunction that will run withinfinish_mergethat will correctly mergeLineSessionsIn
apps/worker/services/processing/merging.py