fix: move tasks to experimental module and undo notifier tauploadcontext #512
Conversation
joseph-sentry
commented
Sep 25, 2025
joseph-sentry
commented
- clarify the tasks that are simply experimental and not actually meant for use in prod currently
- remove TAUploadContext type from commit in BaseNotifier constructor type signature: we don't want to have to worry about this case since it's not being used in prod
- clarify the tasks that are simply experimental and not actually meant for use in prod currently - remove TAUploadContext type from commit in BaseNotifier constructor type signature: we don't want to have to worry about this case since it's not being used in prod
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
=======================================
Coverage 93.81% 93.82%
=======================================
Files 1279 1279
Lines 46087 46080 -7
Branches 1511 1511
=======================================
- Hits 43238 43233 -5
+ Misses 2541 2539 -2
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| @@ -0,0 +1,39 @@ | |||
| # Experimental Test Analytics Tasks | |||
|
|
|||
| This module contains an experimental pipeline that mirrors an aspirational Test Analytics (TA) flow. The code is **not** production-ready—each task exists solely for exploration and will evolve substantially before promotion. | |||
There was a problem hiding this comment.
can you add this was generated by claude
| notifier = TestResultsNotifier( | ||
| repo, | ||
| upload_context, | ||
| upload_context, # TODO: this won't work because test results notifier doesn't currently support the TAUpload Context |
There was a problem hiding this comment.
can you elaborate on "this won't work"
Should we just comment out the whole param to avoid the footgun?
