Open
Conversation
Reverts the render_not_found method to use respond_to, matching the pattern used in the exception handler. This fixes MissingTemplate errors when requests come in with JSON format (e.g., from API clients). The previous change (3eeca62) simplified render_not_found but broke JSON responses. Now HTML requests get the proper 404 page while API requests get an empty 404 response. Adds tests for both HTML and JSON format handling.
KimberleyCook
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#upcomingand#pastscope tests inTimecop.travelblocks to freeze time during test executionWorkshop.upcomingandWorkshop.pastscopes useTime.zone.nowwhich changed between test setup and scope evaluation