Skip to content

Use ActiveRecord over Arrays for email lists #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonodrew merged 1 commit into from
Mar 16, 2026
Merged

Use ActiveRecord over Arrays for email lists #2525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions app/controllers/admin/chapters_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,15 @@ def set_chapter
end

def member_emails(chapter, type)
return chapter.send(type).map(&:email).join("\n") if %w[students coaches].include?(type)

chapter.members.pluck(:email).uniq.join("\n")
members =
case type
when "students"
chapter.students
when "coaches"
chapter.coaches
else
chapter.members
end
members.distinct.pluck(:email).join("\n")
end
end
8 changes: 6 additions & 2 deletions app/models/chapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,15 @@ def organisers
end

def students
members.select(&:student?)
Member.joins(:groups)
.merge(Group.students)
.distinct
end

def coaches
members.select(&:coach?)
Member.joins(:groups)
.merge(Group.coaches)
.distinct
end

private
Expand Down