Update Go and Java plugin configurations for improved file handling #187
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves file handling for Go and Java runtime plugins by adding dynamic extension support for Go and Windows platform support for Java. The changes also include minor formatting cleanup in the README.
- Go plugin now uses dynamic
{{.Extension}}variable in templates to properly handle different file formats (tar.gz for Linux/macOS, zip for Windows) - Java plugin adds Windows binary path configuration to support Windows platforms
- README formatting improved by removing an unnecessary blank line
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/runtimes/go/plugin.yaml | Updated URL and filename templates to use dynamic Extension variable for cross-platform file format support |
| plugins/runtimes/java/plugin.yaml | Added Windows binary path configuration alongside existing darwin and linux paths |
| README.md | Removed extraneous blank line for cleaner formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| darwin: "Contents/Home/bin/java" | ||
| linux: "bin/java" | ||
| linux: "bin/java" | ||
| windows: "bin/java" |
There was a problem hiding this comment.
Windows binary path is defined here, but there is no corresponding Windows mapping in the os_mapping section (lines 14-16). Without an os_mapping entry for Windows, the download URL template will not work correctly for Windows platforms. Consider adding a Windows mapping similar to other plugins, such as "windows": "windows" in the os_mapping section.
Codacy's Analysis Summary1 new issue (≤ 1 medium issue) Review Pull Request in Codacy →
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
| return codacyIssues | ||
| } | ||
|
|
||
| func buildResultsFromIssues(codacyIssues []map[string]interface{}, artifacts []struct { |
There was a problem hiding this comment.
Codacy found an issue: Method buildResultsFromIssues has 54 lines of code (limit is 50)
1 participant
No description provided.