Fixed crash bug related to CCLabelBMFonts #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick99e99
pushed a commit
to patrick99e99/cocos2d-iphone-classic
that referenced
this pull request
Nov 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kept crashing with EXC_BAD_ACCESS on this line in CCTextureAtlas:
glDrawElements(GL_TRIANGLES, (GLsizei) n*6, GL_UNSIGNED_SHORT, (GLvoid*)(start*6*sizeof(_indices[0])) );Finding others with similar issues led me to a cocos2d-x commit that seems to fix this issue. See links.
In summary: adding
ccGLBindVAO(0);after all calls toglDeleteVertexArrays(1, &_VAOname);seems to fix the issue.More info here:
http://stackoverflow.com/questions/19236534/ios-7-and-cocos2d-exc-bad-access-on-gldrawelements-completely-random
And here:
https://github.com/jllust/cocos2d-x/commit/1f3c1145362c921bf5232c4ffbca4a5245042bae