Skip to content

Include dataset id in submission link#1657

Open
pxsit wants to merge 1 commit intocms-dev:mainfrom
pxsit:fix
Open

Include dataset id in submission link#1657
pxsit wants to merge 1 commit intocms-dev:mainfrom
pxsit:fix

Conversation

@pxsit
Copy link
Contributor

@pxsit pxsit commented Mar 25, 2026

This fixes the issue in #1148
CMS already supports dataset-aware submission URLs in the form /submission/<submission_id>/<dataset_id>

Copilot AI review requested due to automatic review settings March 25, 2026 15:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the AWS admin submissions table so submission-detail links preserve the dataset context when multiple datasets exist, aligning with the already-supported /submission/<submission_id>/<dataset_id> URL shape.

Changes:

  • Update the submission timestamp link in the submissions table macro to include dataset.id.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.72%. Comparing base (b98e44b) to head (5e46b92).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
- Coverage   54.74%   54.72%   -0.02%     
==========================================
  Files         335      335              
  Lines       27400    27400              
==========================================
- Hits        15000    14996       -4     
- Misses      12400    12404       +4     
Flag Coverage Δ
functionaltests 0.00% <ø> (ø)
unittests 54.72% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants