Switch from httr to httr2 dependency#440
Open
pepijn-devries wants to merge 3 commits intocloudyr:masterfrom
Open
Switch from httr to httr2 dependency#440pepijn-devries wants to merge 3 commits intocloudyr:masterfrom
pepijn-devries wants to merge 3 commits intocloudyr:masterfrom
Conversation
… authentication. Switched back to original implementation which seems to work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
httr is no longer actively developed and has gone stale in that respect. Using httr2 will allow easy access to new features like
httr2::req_perform_parallel(), allowing to perform multiple requests simultaneously.Notes
Before merging this PR, there are some things to consider, which may need some more attention:
Deprecated arguments
The httr2 package does neither support
write_disknorwrite_fnarguments. This is why I deprecated them ins3HTTP, and replaced them with thefileargument, which will store the response body in the file path specified byfile.Tests
Tests requiring authentication could not be performed locally, due to missing keys. I did some tests with S3 storage for which I do have keys, and this PR works on it. Note that I have modified tests requiring keys to be skipped if the keys are not present.