Skip to content

fix: Add role="tooltip" to non-modal chart popovers#4222

Merged
Harsh-Anand-Singh merged 1 commit intomainfrom
chart-popover-tooltip
Feb 4, 2026
Merged

fix: Add role="tooltip" to non-modal chart popovers#4222
Harsh-Anand-Singh merged 1 commit intomainfrom
chart-popover-tooltip

Conversation

@avinashbot
Copy link
Member

@avinashbot avinashbot commented Feb 3, 2026

Description

Pretty simple and direct, should filter down to both the old and the new charts.

Related links, issue #, if available: AWSUI-61648

How has this been tested?

Unit tests.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.18%. Comparing base (ed20611) to head (be28604).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4222   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files         883      883           
  Lines       25869    25870    +1     
  Branches     9345     9346    +1     
=======================================
+ Hits        25140    25141    +1     
  Misses        723      723           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Harsh-Anand-Singh Harsh-Anand-Singh added this pull request to the merge queue Feb 4, 2026
Merged via the queue into main with commit e494891 Feb 4, 2026
49 checks passed
@Harsh-Anand-Singh Harsh-Anand-Singh deleted the chart-popover-tooltip branch February 4, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants