fix: Inline isFragment function to remove react-is dependency#4220
Open
fix: Inline isFragment function to remove react-is dependency#4220
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4220 +/- ##
=======================================
Coverage 97.18% 97.18%
=======================================
Files 883 883
Lines 25870 25870
Branches 9347 9347
=======================================
Hits 25141 25141
Misses 682 682
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d2281de to
50f72ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR inlines the isFragment function in the internal vendored react-keyed-flatten-children implementation to completely eliminate the react-is dependency. This builds on PR #3997.
Why?
React 19 renamed the element symbol from react.element to react.transitional.element to detect version mismatches in React and react-is (React PR #28813). This means we can't use react-is if we want to support both React 19 and maintain backward compatibility. Therefore, we need to replace the isFragment function with an internal implementation to make it work with both forward and backward compatibility.
Here is a minimal example of the problem using sandbox
Changes
It makes it easy for review if you go through the commits
How I tested it:
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.