refactor: Consolidate input-like component style utilities #4146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract shared getInputStylesCss() utility from input, textarea, and text-filter components to reduce code duplication and bundle size. - Create src/internal/utils/input-styles.ts with shared style mapping - Update input, textarea, and text-filter to use shared utility - Add comprehensive unit tests for the new utility Bundle size reduction: ~10.6 KB (58%) when multiple components are used.
TrevorBurnham
force-pushed
the
refactor-style-modules
branch
from
6721e6c to
7def754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the style utilities used by the
Input,Textarea, andTextFilterto reduce duplicated logic. This should make maintenance easier while also reducing bundle size: If all three components are used, this cuts down the amount of JS served to the browser by ~10KB.How has this been tested?
I'm not sure how best to test this change.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.