Skip to content

Conversation

@mxschll
Copy link
Member

@mxschll mxschll commented Dec 23, 2025

Description

Fixes incorrect scroll positioning in virtual lists by deferring scrollToIndex calls with requestAnimationFrame. This ensures virtual items are measured before scrolling occurs.

Related links, issue #, if available: AWSUI-61506

How has this been tested?

  • Verified changes manually
  • Changes wend through pipeline
  • Dry-run build request (ID: 7659319803)

Visual changes in scroll positions are expected, since it scrolls correctly.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (1a5715e) to head (831d66c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4134   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files         873      873           
  Lines       25642    25648    +6     
  Branches     9284     9281    -3     
=======================================
+ Hits        24910    24916    +6     
+ Misses        726      685   -41     
- Partials        6       47   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll mxschll marked this pull request as ready for review January 7, 2026 09:27
@mxschll mxschll requested a review from a team as a code owner January 7, 2026 09:27
@mxschll mxschll requested review from Harsh-Anand-Singh and removed request for a team January 7, 2026 09:27
@mxschll mxschll enabled auto-merge January 7, 2026 09:28
@mxschll mxschll requested review from Who-is-PS and removed request for Harsh-Anand-Singh January 7, 2026 09:28
@mxschll mxschll added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit ba5bb55 Jan 7, 2026
50 checks passed
@mxschll mxschll deleted the dev-v3-schomax-AWSUI-61506 branch January 7, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants