generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 211
chore: Implements grouped data support in table (WIP) #3673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pan-kot
wants to merge
1
commit into
main
Choose a base branch
from
feat-grouped-table-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef4a117 to
ddb1f87
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3673 +/- ##
==========================================
+ Coverage 97.17% 97.18% +0.01%
==========================================
Files 882 883 +1
Lines 25824 25924 +100
Branches 9332 9386 +54
==========================================
+ Hits 25095 25195 +100
+ Misses 723 682 -41
- Partials 6 47 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddb1f87 to
0c2340c
Compare
0c2340c to
c79e20a
Compare
c79e20a to
594fb0f
Compare
594fb0f to
c68e2b2
Compare
884e216 to
e3d6600
Compare
e3d6600 to
a299f9b
Compare
a299f9b to
1bfa583
Compare
4b849a5 to
d658e7e
Compare
d658e7e to
be08058
Compare
f21ed70 to
154a036
Compare
154a036 to
7efd8e3
Compare
7efd8e3 to
d63773d
Compare
cec9200 to
8631183
Compare
8631183 to
fc75798
Compare
fc75798 to
ad70e92
Compare
ad70e92 to
e9ffa68
Compare
e9ffa68 to
8cbb031
Compare
8cbb031 to
ecee098
Compare
a1fa094 to
72be29a
Compare
72be29a to
6123151
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Table API was extended with new properties to support expandable tables with data grouping. The new API mirrors the collection result API of the collection hooks (see cloudscape-design/collection-hooks#130). Additionally, the new API includes:
columnDefinitions[index].counter()- render function for column counters. It takes computed itemsCount and selectedItemsCount as arguments. It exists so that: 1) the decision to render counters is explicitly taken by consumers even when the counters are computed by collection hooks; 2) the counters format is controlled by consumers (recommended format is({selected}/{total}); 3) custom counters can be rendered for the first or other columns that use shared styles.ariaLabels.itemSelectionLabelandariaLabels.allItemsSelectionLabelnow additionally take itemsCount and selectedItemsCount as arguments. It allows to include the counter info to the selection control ARIA labels.ariaLabels.itemLoaderSelectionLabelandariaLabels.allItemsLoaderSelectionLabelare introduced to determine the ARIA labels of selection checkboxes added to progressive loading rows (only possible for group selection).renderLoaderCounterrender function is introduced to define counters for progressive loading rows. It takesselectedas argument instead of itemsCount/selectedItemsCount because: 1) progressive loading is not supported by collection hooks, so the respective items count is not computed; 2) partial selection is not possible, so selectedItemsCount can be either 0 or equal to itemsCount.Doc: [Jzs6Ab9ewrbz]
Related PRs:
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.