feat: Add PromptInput component #93
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,77 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Member
There was a problem hiding this comment.
this would need to be the same shared context as in the main repo in order for it to work I think?
| */ | ||
| @use "../../node_modules/@cloudscape-design/design-tokens/index.scss" as cs; | ||
|
|
||
| $font-weight-normal: 400; |
Member
There was a problem hiding this comment.
There is definitely some risk from the duplication in this file. For example, I think there is an ongoing initiative to make typography more themeable, and things in this file might get missed when refactoring in the main repo. I think realistically, anything in here should be exposed as a design token from the main repo.
| @@ -0,0 +1,80 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Member
There was a problem hiding this comment.
should probably go to components-toolkit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add PromptInput from components to this package.
Related links, issue #, if available: n/a
How has this been tested?
Original unit tests carried over, integration tests missing, none in chat-components
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.