Skip to content

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Sep 18, 2024

Upgraded WebdriverIO from v7 to v9.

See: [ygtJAKJyEnsh] and CR-167061092.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.66%. Comparing base (24e0952) to head (80264b6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/page-objects/full-page-screenshot.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   91.25%   91.66%   +0.41%     
==========================================
  Files          18       18              
  Lines         400      396       -4     
  Branches       66       63       -3     
==========================================
- Hits          365      363       -2     
+ Misses         31       29       -2     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot force-pushed the chore-webdriverio9 branch 4 times, most recently from b7b164c to 74b9208 Compare September 19, 2024 08:16
@pan-kot pan-kot force-pushed the chore-webdriverio9 branch 5 times, most recently from ea0e193 to e4cab7a Compare September 26, 2024 10:34
@pan-kot pan-kot force-pushed the chore-webdriverio9 branch 2 times, most recently from fac7f44 to 52f7bbc Compare October 16, 2024 10:50
@pan-kot pan-kot force-pushed the chore-webdriverio9 branch 3 times, most recently from 5a4aed9 to e471510 Compare December 19, 2024 19:29
@pan-kot pan-kot marked this pull request as ready for review December 20, 2024 05:33
@pan-kot pan-kot requested a review from a team as a code owner December 20, 2024 05:33
@pan-kot pan-kot requested review from cansuaa and removed request for a team December 20, 2024 05:33
cansuaa
cansuaa previously approved these changes Jan 8, 2025
Copy link
Member

@cansuaa cansuaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preparing a document explaining why each change was done, it was really helpful.

Comment on lines +20 to +23
import { Browser } from 'webdriverio';

export default class BasePageObject {
constructor(protected browser: WebdriverIO.Browser) {}
constructor(protected browser: Browser) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

@pan-kot pan-kot added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@pan-kot pan-kot added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@pan-kot pan-kot added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit e304672 Feb 13, 2025
37 checks passed
@pan-kot pan-kot deleted the chore-webdriverio9 branch February 13, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants