-
Notifications
You must be signed in to change notification settings - Fork 2
chore: Upgrades WebdriverIO to v9 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 91.25% 91.66% +0.41%
==========================================
Files 18 18
Lines 400 396 -4
Branches 66 63 -3
==========================================
- Hits 365 363 -2
+ Misses 31 29 -2
Partials 4 4 ☔ View full report in Codecov by Sentry. |
b7b164c to
74b9208
Compare
74b9208 to
318f6e6
Compare
ea0e193 to
e4cab7a
Compare
fac7f44 to
52f7bbc
Compare
7fc85ed to
fc3e1c3
Compare
5a4aed9 to
e471510
Compare
cansuaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for preparing a document explaining why each change was done, it was really helpful.
| import { Browser } from 'webdriverio'; | ||
|
|
||
| export default class BasePageObject { | ||
| constructor(protected browser: WebdriverIO.Browser) {} | ||
| constructor(protected browser: Browser) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
4362299 to
3377919
Compare
3377919 to
dfe1c1a
Compare
dfe1c1a to
80264b6
Compare
Upgraded WebdriverIO from v7 to v9.
See: [ygtJAKJyEnsh] and CR-167061092.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.