Skip to content

chore: Extract common visual theme code into helper function#339

Merged
michaeldowseza merged 1 commit intomainfrom
visual-theme
Mar 19, 2025
Merged

chore: Extract common visual theme code into helper function#339
michaeldowseza merged 1 commit intomainfrom
visual-theme

Conversation

@michaeldowseza
Copy link
Member

@michaeldowseza michaeldowseza commented Mar 18, 2025

Description

Ports over helper function from cloudscape-design/components#3355

Related links, issue #, if available: n/a

How has this been tested?

  • Copied over unit tests

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (7468aa5) to head (ddbd104).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   93.59%   93.66%   +0.06%     
==========================================
  Files          61       68       +7     
  Lines        4312     3124    -1188     
  Branches      525      670     +145     
==========================================
- Hits         4036     2926    -1110     
+ Misses        276      194      -82     
- Partials        0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michaeldowseza michaeldowseza marked this pull request as ready for review March 18, 2025 16:40
@michaeldowseza michaeldowseza requested a review from a team as a code owner March 18, 2025 16:40
@michaeldowseza michaeldowseza requested review from a team, connorlanigan and orangevolon and removed request for a team and connorlanigan March 18, 2025 16:40
@michaeldowseza michaeldowseza added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit 82f8ef6 Mar 19, 2025
39 of 41 checks passed
@michaeldowseza michaeldowseza deleted the visual-theme branch March 19, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants