Skip to content

Conversation

@jsignell
Copy link
Collaborator

First draft of #134 borrowing heavily from conversation on that issue.

Copy link
Collaborator

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thank you @jsignell!

This is a tremendous resource as-is! I think it could be taken to the next level, separately from this PR, by having a small demonstration of catalogs that employ each of these approaches perhaps with a STAC browser on top. Do you have any plans to build of resource of that type? I'd be glad to help.

Comment on lines 66 to 68
- Store the result of a data-cube constructed by concatenating Zarr stores:
- as a new Zarr store - this option can include filtering and subsetting
- as a virtual reference file (icechunk or kerchunk)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdsumner have you tried out concatenating Zarr stores via VRT/GTI? I'm struggling to keep up with your work, but thought you may have shared this as an option as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! I had seen https://www.hypertidy.org/posts/2025-03-12-r-py-multidim/r-py-multidim but I need to revisit and link out.

@maxrjones
Copy link
Collaborator

This is a tremendous resource as-is! I think it could be taken to the next level, separately from this PR, by having a small demonstration of catalogs that employ each of these approaches perhaps with a STAC browser on top. Do you have any plans to build of resource of that type? I'd be glad to help.

Actually, I'm now wondering if even adding some drawing to these pages would help clarify the concepts as much or more than a full demonstration.

@maxrjones
Copy link
Collaborator

I also wonder if the virtual zarr section should include some guidance on how to organize cataloging of the raw data with cataloging of the virtual Zarr references/stores?

@jsignell
Copy link
Collaborator Author

This is a tremendous resource as-is! I think it could be taken to the next level, separately from this PR, by having a small demonstration of catalogs that employ each of these approaches perhaps with a STAC browser on top. Do you have any plans to build of resource of that type? I'd be glad to help.

Actually, I'm now wondering if even adding some drawing to these pages would help clarify the concepts as much or more than a full demonstration.

Yes! I think adding drawings could be really helpful. I was struggling with how to structure the sections, but once we settle on that drawings would really be useful. I think it would also help to just point to examples that implement the different setups.

@jsignell
Copy link
Collaborator Author

I also wonder if the virtual zarr section should include some guidance on how to organize cataloging of the raw data with cataloging of the virtual Zarr references/stores?

Yeeeaaahhh I wasn't at sure how much to talk about virtual zarr... but I can imagine a scenario where you catalog the data in normal stac objects but then also include a top-level reference file/store so that you have best of both worlds in terms of data access, but then you have 2 ways of accessing data and 2 places where you are abstracting metadata so I wasn't sure if that is a good idea.

@maxrjones
Copy link
Collaborator

I also wonder if the virtual zarr section should include some guidance on how to organize cataloging of the raw data with cataloging of the virtual Zarr references/stores?

Yeeeaaahhh I wasn't at sure how much to talk about virtual zarr... but I can imagine a scenario where you catalog the data in normal stac objects but then also include a top-level reference file/store so that you have best of both worlds in terms of data access, but then you have 2 ways of accessing data and 2 places where you are abstracting metadata so I wasn't sure if that is a good idea.

Maybe a good balance would be just to open an issue for a TODO on additional guidance for cataloguing both raw data and virtual zarrs and mention that issue in this new section, so readers are aware it's not fully comprehensive.

@jsignell
Copy link
Collaborator Author

jsignell commented Apr 1, 2025

Ok I did the text changes and added links to data-consumers at least. I'm going to work on some drawings next.

@jsignell
Copy link
Collaborator Author

jsignell commented Apr 9, 2025

Ok I made these diagrams:

image
image

Copy link
Contributor

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to get around to another read-through. I really like it ... feels like all the "big ideas" for STAC (i.e. STAC isn't for data, STAC is good at L2 and below, etc) are covered.

I did a read-through mostly with my "experienced practitioner" hat on, so I don't have much feedback yet on how it might read to someone newer to the space. Depending on when this is intended to ship, I can try to take another pass next week from a "newcomer" perspecitve (if I even can get to that perspective 😬).

@jsignell
Copy link
Collaborator Author

jsignell commented May 6, 2025

Ok I am going to try to make this build work and then I feel like this is in a pretty good spot!

@jsignell jsignell requested a review from gadomski May 6, 2025 16:50
@jsignell
Copy link
Collaborator Author

jsignell commented May 6, 2025

My understanding is that this fork needs to be merged to staging before the preview action will work.

@wildintellect
Copy link
Contributor

@jsignell yes only branches on the primary fork work with preview, we should actually disable attempts to preview remote forks.

@wildintellect wildintellect merged commit 7587db5 into cloudnativegeo:staging May 6, 2025
2 of 3 checks passed
@jsignell jsignell mentioned this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants