replace wildcard data property with per-instance proxy#6071
Open
dcarney-cf wants to merge 1 commit intomainfrom
Open
replace wildcard data property with per-instance proxy#6071dcarney-cf wants to merge 1 commit intomainfrom
dcarney-cf wants to merge 1 commit intomainfrom
Conversation
jasnell
reviewed
Feb 13, 2026
| auto reflectGetFn = check(reflectObj->Get(context, v8StrIntern(isolate, "get"))); | ||
| auto handler = v8::Object::New(isolate); | ||
| check(handler->Set(context, v8StrIntern(isolate, "get"), | ||
| v8::Function::New(context, proxyGetTrap, reflectGetFn).ToLocalChecked())); |
Collaborator
There was a problem hiding this comment.
We avoid using ToLocalChecked... the check(...) should handle things correctly.
Contributor
Author
There was a problem hiding this comment.
thanks. will fix. don't look too hard at this, as it still needs a bunch of cleanup. it's more of the approach that needs to be considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.