Skip to content

feat(kumo): add ColorPicker with docs and registry integration#264

Closed
singkia wants to merge 3 commits intocloudflare:mainfrom
singkia:codex/color-picker-upstream-parity
Closed

feat(kumo): add ColorPicker with docs and registry integration#264
singkia wants to merge 3 commits intocloudflare:mainfrom
singkia:codex/color-picker-upstream-parity

Conversation

@singkia
Copy link
Copy Markdown
Contributor

@singkia singkia commented Mar 18, 2026

Summary

  • add a ColorPicker component with hex-in hex-out behavior, popover panel, HSB area, hue slider, format switching, and progressive EyeDropper support
  • add the Color Picker docs page and demo set, and wire it into docs navigation and search
  • update registry metadata and generated artifacts so the API reference exposes the current public props, including onChange
  • tighten the trigger layout and add regression coverage for controlled value syncing, normalized hex commits, and swatch-only rendering

Testing

  • pnpm tsx ci/scripts/validate-kumo-changeset.ts
  • pnpm --filter @cloudflare/kumo exec vitest run --project=unit src/components/color-picker/color-picker.test.tsx
  • pnpm --filter @cloudflare/kumo exec vitest run scripts/component-registry/index.test.ts
  • pnpm --filter @cloudflare/kumo codegen:registry

@singkia
Copy link
Copy Markdown
Contributor Author

singkia commented Mar 18, 2026

Manual verification on the docs page:

  • /components/color-picker loads and the hero demo renders correctly
  • search returns Color Picker with the dedicated summary
  • PropsTable component="ColorPicker" renders and now includes onChange
  • the swatch-only and disabled examples behave as expected

I did not attach screenshots here because the change is straightforward to review in the docs preview and the PR body already covers the scope.

@singkia
Copy link
Copy Markdown
Contributor Author

singkia commented Mar 20, 2026

Color Picker is now fully wired into the docs surface:

  • Sidebar: Color Picker is now listed in the component nav.
  • Search: ColorPicker now appears as a dedicated search result.
  • Docs page: /components/color-picker now exists with demos and API reference.
Area Before After
Sidebar Before sidebar After sidebar
Search Before search After search
Docs page Before docs page After docs page


Close-up from the docs page:

image

singkia added 2 commits April 2, 2026 03:43
Add the ColorPicker docs page and demo suite, wire the component into docs navigation and search, and refresh the registry artifacts so the public API reference includes the current props. Also tighten the trigger layout and add regression coverage for controlled updates, normalized hex commits, and swatch-only rendering.
@singkia singkia force-pushed the codex/color-picker-upstream-parity branch from 6ef282d to d6509ba Compare April 1, 2026 19:45
@stritt
Copy link
Copy Markdown
Collaborator

stritt commented Apr 8, 2026

hey singkia appreciate all of your contributions but this is not a component we are actively looking to support at the moment, it could be something to revisit in the future though. i am closing for now.

@stritt stritt closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants