Add maxTokens support to WorkersAi chat and handle non-string responses#459
Merged
threepointone merged 2 commits intocloudflare:mainfrom Mar 25, 2026
Merged
Add maxTokens support to WorkersAi chat and handle non-string responses#459threepointone merged 2 commits intocloudflare:mainfrom
threepointone merged 2 commits intocloudflare:mainfrom
Conversation
Contributor
TimoWilhelm
commented
Mar 23, 2026
- Extract maxTokens from options in chatStream and pass as max_tokens to both streaming and non-streaming run. - Update createWorkersAiBindingFetch to stringify object responses when building assistant messages instead of defaulting to empty string.
Extract maxTokens from options in chatStream and pass as max_tokens to both streaming and non-streaming binding.run calls. Update createWorkersAiBindingFetch to stringify object responses when building assistant messages instead of defaulting to empty string.
🦋 Changeset detectedLatest commit: a375d3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Add support for forwarding maxTokens from TextOptions to the Workers AI binding as max_tokens (streaming and non-streaming paths). Update createWorkersAiBindingFetch to stringify object responses from the binding when building assistant messages and default to an empty string for non-string/non-object or null responses. Add tests to verify object stringification, null/non-object handling, and max_tokens forwarding, and include a changeset entry documenting the patch.
Collaborator
|
Thanks for the PR! I've pushed a few additions on top of your commit: Formatting fix: Broke the long ternary in Changeset: Added Tests (6 new, all passing): In
In
Note: |
threepointone
approved these changes
Mar 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.