Revisión de la práctica DASS01 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inicialización del pool y rellenado antes de cada test. Vaciado del pool despés de cada test.
ReusablePoolTest.
nulo y prueba para liberación excesiva de objetos.
Modificado el método release de ReusablePool para comtemplar los casos en que se intenta liberar un objeto nulo o liberar mas objetos cuando el pool está lleno. Añadido en Client la posibilidad de lanzar una FullPoolException. Modificado el orden de las comprobaciones del test que comprueba las liberaciones.
Owner
Author
|
Respecto al commit 089d527 |
| // se intenta liberar el mismo objeto reusable, | ||
| // DuplicatedInstanceException | ||
| pool.releaseReusable(reusable1); | ||
| fail("Se esperaba excepción de tipo DuplicatedInstanceException"); |
Owner
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
La práctica cumple correctamente los objetivos planteados tanto a nivel de producto como de proceso.
Añado una revisión de código para mejorar el producto y estilo de codicación.
Los comentarios estarán tanto a nivel global como dentro de las propias líneas de código.