fix: Make cider close robust to directory removal #3856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the parent directory of the history file no longer exists (common when using git worktrees that get removed while CIDER is running), emit a warning instead of throwing an error. This allows CIDER to close gracefully when the worktree directory has been deleted.
Add buttercup tests for cider-repl--history-write covering: - Normal write succeeds (baseline) - Parent directory missing emits warning, returns gracefully - File not writable but parent exists raises error
Member
|
One test seems to be failing: |
Root user bypasses file permissions, causing file-writable-p to return t even for 444 files. Mock file-writable-p only when running as root to allow the test to pass in CI environments (which typically run as root) while still testing real file permissions on normal systems.
hugoduncan
force-pushed
the
1-make-cider-close-robust
branch
from
2197317 to
90dedf4
Compare
Member
|
Thanks! I've fixed separate the outdated macOS images that were causing unrelated failures. |
Member
Author
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using git worktrees, it is very easy to remove the worktree before a REPL running in that directory is closed. Currently in this case, CIDER complains the cider-history file cannot be written and errors.
This PR modifies
cider-repl--history-writeso that if the file is not writable due to the parent directory no longer existing, it emits a warning viamessageand skips writing the file (returns early without error).Changes
cider-repl--history-writeto check if parent directory exists when file is not writableCommits
7bb8f848fix: Handle missing parent directory in history write8ed71452test: Add tests for history write edge caseseldev test)eldev lint)