Skip to content

Conversation

@steepnicki
Copy link
Member

Summary

  • feat: Adapt the engine collection calls to MongoDB 8 (from callbacks to promises, but still return callbacks from the engine to ensure compatibility)

Evidence

Any caveats, potential risks or outstanding actions?

…to promises, but still return callbacks from the engine to ensure compatibility)
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @steepnicki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the save-mongodb package to support MongoDB version 8. It modifies the internal implementation to use promises while maintaining callback compatibility, updates dependencies, and modernizes the codebase with ES6 syntax.

Highlights

  • MongoDB 8 Support: This PR adapts the engine collection calls to be compatible with MongoDB 8 by changing callbacks to promises internally, while still returning callbacks from the engine to ensure compatibility with existing code.
  • Dependency Update: The peer dependency of mongodb has been updated to ^8.
  • Node.js Engine Update: The minimum required Node.js version has been bumped to 18.
  • Code Modernization: The code has been updated to use const instead of var for variable declarations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the library to support MongoDB 8 by upgrading the mongodb driver to v6. The changes primarily involve refactoring database calls from using callbacks to promises, while maintaining the existing callback-based public API for backward compatibility. The test suite has also been modernized to use async/await, improving readability.

@socket-security
Copy link

socket-security bot commented Jun 27, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​types/​whatwg-url@​8.2.1 ⏵ 11.0.5100 +110071 -177100
Updatedmongodb-connection-string-url@​2.5.2 ⏵ 3.0.210010075 +185100
Added@​mongodb-js/​saslprep@​1.3.01001008091100
Updatedtr46@​3.0.0 ⏵ 5.1.1100 +11009384100
Updatedwhatwg-url@​11.0.0 ⏵ 14.2.0100 +1100100 +185100
Updatedbson@​4.6.4 ⏵ 6.10.4100 +110010092100
Updatedmongodb@​4.6.0 ⏵ 6.16.097 -1100 +510099 +2100

View full report

@steepnicki steepnicki force-pushed the feature/mongodb-8-conversion branch from 61676cc to 3f81c6b Compare June 27, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants