Skip to content

Conversation

@kevinjqliu
Copy link
Collaborator

@kevinjqliu kevinjqliu commented Jan 13, 2026

Great suggestion from @alamb to add a --quiet flag that suppresses all output, #220 (review)
--quiet sets the log level to ERROR so the CLI can still display error logs

I also took the opportunity to refactor the remaining usages of eprintln! and println!, replacing them with log statements.

We still retain the behavior implemented in #220; the cli still warns when skip generation
Screenshot 2026-01-13 at 2 20 35 PM

@alamb alamb changed the title cli: add --quiet flag cli: add --quiet flag, enable logging by default Jan 17, 2026
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me -- thank you @kevinjqliu !

I tried it out and it works great

(venv) andrewlamb@Andrews-MacBook-Pro-3:~/Software/tpchgen-rs$ cargo run --bin tpchgen-cli --release --  -s 0.1
    Finished `release` profile [optimized] target(s) in 0.18s
     Running `target/release/tpchgen-cli -s 0.1`
[2026-01-17T00:53:45Z WARN  tpchgen_cli::runner] ./region.tbl already exists, skipping generation
[2026-01-17T00:53:45Z WARN  tpchgen_cli::runner] ./orders.tbl already exists, skipping generation
[2026-01-17T00:53:45Z WARN  tpchgen_cli::runner] ./part.tbl already exists, skipping generation
[2026-01-17T00:53:45Z WARN  tpchgen_cli::runner] ./customer.tbl already exists, skipping generation
[2026-01-17T00:53:45Z WARN  tpchgen_cli::runner] ./lineitem.tbl already exists, skipping generation
[2026-01-17T00:53:45Z WARN  tpchgen_cli::runner] ./nation.tbl already exists, skipping generation
[2026-01-17T00:53:45Z WARN  tpchgen_cli::runner] ./partsupp.tbl already exists, skipping generation
[2026-01-17T00:53:45Z WARN  tpchgen_cli::runner] ./supplier.tbl already exists, skipping generation
(venv) andrewlamb@Andrews-MacBook-Pro-3:~/Software/tpchgen-rs$ cargo run --bin tpchgen-cli --release -- --quiet  -s 0.1
    Finished `release` profile [optimized] target(s) in 0.06s
     Running `target/release/tpchgen-cli --quiet -s 0.1`
(venv) andrewlamb@Andrews-MacBook-Pro-3:~/Software/tpchgen-rs$

FYI @clflushopt

@kevinjqliu kevinjqliu merged commit b91de80 into clflushopt:main Jan 17, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants