feat(nui): game capture rework #3763
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Rework parts of game view capture and
application/x-cfx-game-viewto improve performance and functionality while maintaining backwards compatibility.The single (deprecated) pepper plugin usage in cef which was used for
application/x-cfx-game-viewhas been removed in favour of a native js canvas rendering. Pepper Plugins were removed in cef >m104 and can be re-implemented inside of JS.FiveM's implementation was simplified, moving the GL -> DX coordinate conversion (this also changes in newer cef versions) into NUI whilst providing backwards compatibility for the citizenfx/three.js fork and other implementations. Whilst providing
CfxGameViewRender, which is based off of the fxdk GameViewRender class for other nui scripts to make use of instead of their own implementations.Moving away from using shaders to handle the GL -> DX coordinate conversion also resolves compatibility/instability issues with some reshade addons
On top of this game view capture has been implemented into RedM (DX12 only currently)
How is this PR achieving the goal
Backported changes from the CEF upgrade I experimented with. This is still a work in progress patch and will be improved upon with Vulkan support in the near future
This PR applies to the following area(s)
FiveM, RedM
Successfully tested on
Game builds: 3258 (FiveM), 1491 (RedM)
Platforms: Windows
Checklist
Fixes issues