fix(citizen-server-impl): prevent clients from creating multiple CNetObjPlayer #3755
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ObjPlayer Co-Authored-By: Ethan <[email protected]> Co-Authored-By: Gogsi <[email protected]>
github-actions
bot
added
the
invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
It fixes an exploit: malicious clients created multiple CNetObjPlayer instances, and when teleporting away, the reference to the player's PlayerInfo was lost because they left their CNetObjPlayer clones in the same place, causing nearby players to crash because they didn't have a valid pointer to the PlayerInfo from those "clones".
How is this PR achieving the goal
Not allowing clients to create more than one CNetObjPlayer.
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 3570
Platforms: Windows
Checklist
Fixes issues
fixes #3751, fixes #3754