feat(script-runtimes/v8): add memory info per context #3741
+200
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ScRT: JS
AvarianKnight
force-pushed
the
feat/v8-memory-info
branch
from
34393d0 to
ecbb65f
Compare
github-actions
bot
added
triage
This uses the experimental `MeasureMemory` api to measure all of the context's used memory and stores the amount of used memory into the global `g_memoryInfo`. This should add a decent bit of debugability to existing scripts that use V8, and hopefully help script devs figure out if they're using a lot of memory. In the future it might make sense to have a "common" v8 class that we can use to share structure between the new Node ScRT and the v8 ScRT to reduce the duplication here. This also cleans up some existing code by using the `CfxV8EmbeddedData` enum to better describe what certain embedder data does.
AvarianKnight
force-pushed
the
feat/v8-memory-info
branch
from
ecbb65f to
30030cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the experimental
MeasureMemoryapi to measure all of the context's used memory and stores the amount of used memory into the globalg_memoryInfo.This should add a decent bit of debugability to existing scripts that use V8, and hopefully help script devs figure out if they're using a lot of memory.
In the future it might make sense to have a "common" v8 class that we can use to share structure between the new Node ScRT and the v8 ScRT to reduce the duplication here.
This also cleans up some existing code by using the
CfxV8EmbeddedDataenum to better describe what certain embedder data does.Goal of this PR
Add memory tracking to the v8 environment
This PR applies to the following area(s)
ScRT: JS, ScRT: Node
Successfully tested on
Game builds: 1491
Platforms: Windows
Checklist
Fixes issues