feat(core/rdr3): improved rage pool error messages #3740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RDR3, Rage Errors 0x496AC5DF:961 (entity component pool) and 0x9952DB5E:212 (unique archetype related pools) are two full pool related errors that don't provide much value to the end user/server owner and can't be used on its own to debug the issue. This patch replaces those errors with actionable information to allow server owners to resolve these issues on their own
github-actions
bot
added
RedM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Replaces two common rage errors players and server owners face 0x496AC5DF:961 and 0x9952DB5E:212 with more specific error messages describing what failed and allowing a server owner to potentially resolve the issue (in these cases by increasing the size of the pool mentioned)
How is this PR achieving the goal
replace all cases of 0x496AC5DF:961 and 0x9952DB5E:212 with custom logic to identify the problematic pool and provide a useful error message to the user instead of the generic "RAGE ERROR: 0x496AC5DF:961/0x9952DB5E:212"
This PR applies to the following area(s)
RedM
Successfully tested on
Tested on release and debug by decreasing certain pools (CPedAnimationComponent for 0x496AC5DF:961 and fwDynamicArchetypeComponent for 0x9952DB5E:212)
Game builds: 1491
Platforms: Windows, Linux
Checklist
Fixes issues