fix(system-resources/chat): colorize message parameters directly #3705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix a bug where given a chat template such as
<span class="content">{0}</span>, sending colored messages such as~b~testor^1testwould remove the surrounding<span class="content">element.How is this PR achieving the goal
Colorize the template parameters directly before passing them to the template.
Currently, the entire template is passed to the
colorizemethod, which:<span class="content">^1test</span>(^1testis the{0}parameter in this case)<span><span class="content">^1test</span></span></span><span class="some-color-class">:<span><span class="content"></span><span class="color-1">test</span></span><span><span class="color-1">test</span></span>If we colorize the parameters beforehand, the surrounding template element would not be affected by the parameters, as they would already be colorized.
This PR applies to the following area(s)
FiveM, RedM
Checklist