feat(extra-natives-rdr3): Add GET_VEHICLE_ADDITIONAL_PROP_SET_HASH na…

[Identity-labs]

Goal of this PR

Add GET_VEHICLE_ADDITIONAL_PROP_SET_HASH native to enable access to vehicle additional propset hash functionality, like we have on main vehicle propset GET_VEHICLE_PROP_SET_HASH
Why ? to avoid storing the data on every entity using statebag when you want to init your list at the current selected additional propset

How is this PR achieving the goal

Native Implementation:

• Added GET_VEHICLE_ADDITIONAL_PROP_SET_HASH native declaration and implementation
• Implemented proper vehicle type checking using IsOfType() template
• Added error handling for invalid vehicle entities

Supporting Infrastructure:

• Refactor duplicated code in NativeWrappers.h by using EntitySystem.h like it's done in FiveM
• Implemented missing IsOfType(uint32_t hash) and IsOfTypeH(uint32_t hash) functions

This PR applies to the following area(s)

RedM, Natives, Vehicle System, EntitySystem

Successfully tested on

Game builds: RedM latest

Platforms: Windows

Checklist

• Code compiles and has been tested successfully.
• Code explains itself well and/or is documented.
• My commit message explains what the changes do and what they are for.
• No extra compilation warnings are added by these changes.

[prikolium-cfx]

Could you please share more information about what propset for vehicle is?

[Identity-labs]

On vehicle you can set main and additional propset (secondary)
ADD_PROP_SET_FOR_VEHICLE
0xD80FAF919A2E56EA
ADD_ADDITIONAL_PROP_SET_FOR_VEHICLE
0x75F90E4051CC084C

Native are called ADD but it more a SET than an ADD

But you can only get the main propset with GET_VEHICLE_PROP_SET_HASH not the additional

On a vehicle a propset is used to add various props on the vehicle like with entitySets in a MLO

[prikolium-cfx]

On vehicle you can set main and additional propset (secondary) ADD_PROP_SET_FOR_VEHICLE 0xD80FAF919A2E56EA ADD_ADDITIONAL_PROP_SET_FOR_VEHICLE 0x75F90E4051CC084C

Native are called ADD but it more a SET than an ADD

But you can only get the main propset with GET_VEHICLE_PROP_SET_HASH not the additional

On a vehicle a propset is used to add various props on the vehicle like with entitySets in a MLO

Thank you

[prikolium-cfx]

Looks like is repeating behavior of Hook::FlexStruct. Please use FlexStruct where possible to reduce code duplication. Also for virtual method calls below

[Identity-labs]

Done, thx for your review

[prikolium-cfx]

this call can be done with FlexStruct as well and will look better

[Identity-labs]

I have done the change to access to the memory address, i have try to directly use CallVirtual without success

[prikolium-cfx]

I have done the change to access to the memory address, i have try to directly use CallVirtual without success

Can you show me how you use CallVirtual?

[prikolium-cfx]

It should work. No need to pass this, it will be passed automatically

return ((Hook::FlexStruct*)this)->CallVirtual<bool, const uint32_t&>(1, hash); 

[Identity-labs]

i have try

bool fwEntity::IsOfTypeH(uint32_t hash)
{
    hook::FlexStruct* flexStruct = reinterpret_cast<hook::FlexStruct*>(this);
    return flexStruct->CallVirtual<bool>(sizeof(void*), static_cast<const uint32_t&>(hash));
}
bool fwEntity::IsOfTypeH(uint32_t hash)
{
    hook::FlexStruct* flexStruct = reinterpret_cast<hook::FlexStruct*>(this);
    return flexStruct->CallVirtual<bool>(1, static_cast<const uint32_t&>(hash));
}

And your way make the game crash

bool fwEntity::IsOfTypeH(uint32_t hash)
{
    hook::FlexStruct* flexStruct = reinterpret_cast<hook::FlexStruct*>(this);
    return flexStruct->CallVirtual<bool, const uint32_t&>(1, hash);
}

[Identity-labs]

Ok with sizeof(void*) instead of 1 it's ok

[prikolium-cfx]

Ok with sizeof(void*) instead of 1 it's ok

Right, sorry, there should be real offset in bytes in virtual table.