feat(scoreboard): Scoreboard rewrite. #159
Conversation
Co-Authored-By: Christopher Gjelten <[email protected]>
|
Egh. |
|
@blattersturm Anything you'd like to see changed? |
| -- Altering or recreating for local use only is strongly discouraged. | ||
|
|
||
| version '1.0.0' | ||
| author 'Chip & Neco' |
There was a problem hiding this comment.
Bundled assets should be a generic name since we're not using the fxports system at this time.
| } | ||
|
|
||
| game 'gta5' | ||
| fx_version 'adamant' |
There was a problem hiding this comment.
Meh. Is this compliant to any newer versions' stuff?
| @@ -0,0 +1,74 @@ | |||
| @import url('https://fonts.googleapis.com/css2?family=Rubik:wght@400;500;600&display=swap'); | |||
There was a problem hiding this comment.
Remote dependencies are a no.
There was a problem hiding this comment.
I assume you'd like me to download the font instead?
| } | ||
|
|
||
| .content-table tbody tr:nth-child(2n) { | ||
| color: #fff; |
There was a problem hiding this comment.
Why are these both the exact same?
| html | ||
| node_modules | ||
| .yarn.installed | ||
| yarn.lock |
There was a problem hiding this comment.
Don't ignore yarn.lock.
| document.getElementById('root') | ||
| ); | ||
|
|
||
| // If you want to start measuring performance in your app, pass a function |
There was a problem hiding this comment.
Well, good old CRA comment. Can delete it.
| @@ -0,0 +1,15 @@ | |||
| import { ReportHandler } from 'web-vitals'; | |||
|
|
|||
| const reportWebVitals = (onPerfEntry?: ReportHandler) => { | |||
There was a problem hiding this comment.
Yeah, we can honestly delete both this and the test file....
| **/ | ||
| const defaultOptions = {}; | ||
|
|
||
| export const useNuiEvent = <S = Record<string, unknown>>( |
There was a problem hiding this comment.
Cute. Where'd this get copied from?
There was a problem hiding this comment.
An resource I am currently working on.
|
|
||
| module: { | ||
| rules: [ | ||
| { |
| DisableControlAction(0, 2, true) | ||
| DisableControlAction(0, 16, true) | ||
| DisableControlAction(0, 17, true) | ||
| end |
There was a problem hiding this comment.
No re-request for users who hold it for >1 second either? :(
|
:o new review
will check soon
Sent from ProtonMail for iOS
…On Sun, Mar 21, 2021 at 19:12, Lewis ***@***.***> wrote:
***@***.***(https://github.com/The-Neco) requested your review on: [#159](#159) feat(scoreboard): Scoreboard rewrite..
—
You are receiving this because your review was requested.
Reply to this email directly, [view it on GitHub](#159 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AF3QBATJISRZRSJU5RG5AYLTEYZJFANCNFSM4ZPMDK6Q).
|
Free for All gamemode witch integrates with mapmanger and spawnmanager. Also requires new scoreboard in PR citizenfx#159. Co-Authored-By: Christopher Gjelten <[email protected]>
|
Sorry for the delay - I'm still intending to merge it next time I make a pass at this repo. |
Added additional disabled keys as mentioned by @RockySouthpaw.
4 participants
Full scoreboard rewrite and redesign with a column API allowing for resources to add custom columns to the scoreboard on the fly.
New events added in this commit:
scoreboard:addColumn
Adds a column to the scoreboard in the specified position with a default value.
scoreboard:removeColumn
Removes the specified column.
scoreboard:updateColumnValue
Updates the specified column value for the specified player.
Co-Authored-By: Christopher Gjelten [email protected]