This repository was archived by the owner on Jan 27, 2023. It is now read-only.
Dockerise the build #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why did I do this? 1. Our builds had stopped working on a Mac because of use of `sed` in a build script - the Mac and Linux versions are different 2. asdf tool proliferation has become a thing across our projects 3. I can no longer get asdf postgres to install successfully on my mac The base image (ubuntu:latest) will install a version appropriate to your host architecture - i.e. x86_64 or arm64 so nobody has to pay an unfair performance penalty. It takes about 2 minutes to build the image. Once built, commands can be executed in the container with the host repo mounted inside of it. There does not appear to be any noticable performance drop in build times but I have not run benchmarks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why did I do this?
sedin a build script - the Mac and Linux versions are differentThe base image (ubuntu:latest) will install a version appropriate to your host architecture - i.e. x86_64 or arm64 so nobody has to pay an unfair performance penalty.
It takes about 2 minutes to build the image. Once built, commands can be executed in the container with the host repo mounted inside of it. There does not appear to be any noticable performance drop in build times but I have not run benchmarks.