Fix impulse reverb audio chain and remove UI separators #276
+5
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2026 23:39
The impulse reverb (kick_ir, diffusor_ir, telephone_ir, muffler_ir) was producing no audio output because cleanupEffectChain() disconnects the source node but connectImpulseReverb() never reconnected it to the gain node, breaking the audio chain.
Simplify layout by removing vertical separator elements and adjusting gap spacing for cleaner visual appearance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Impulse Reverb Fix
connectImpulseReverb()was callingcleanupEffectChain()which disconnects the source node, but never reconnected it to the gain nodesource.connect(gainNode)call to restore the audio chainUI Styling
Test plan