Skip to content

Conversation

@mr-c
Copy link

@mr-c mr-c commented Jan 8, 2026

Fixes: #767

For the Debian package of cheroot we need Python 3.14 support, and I noticed modifying and adapting the Python3.13 specific warning for Python 3.14 was enough to get the tests to pass with Python 3.14.

What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • 📋 docs update
  • 📋 tests/coverage improvement
  • 📋 refactoring
  • 💥 other

📋 What is the related issue number (starting with #)

Resolves #767

📋 Other information:

📋 Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.19%. Comparing base (662cd9d) to head (372d3e0).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
- Coverage   78.38%   78.19%   -0.19%     
==========================================
  Files          41       41              
  Lines        4788     4788              
  Branches      547      547              
==========================================
- Hits         3753     3744       -9     
- Misses        896      905       +9     
  Partials      139      139              

@mr-c
Copy link
Author

mr-c commented Jan 8, 2026

  • cheroot/test/test_ssl.py::test_tls_client_auth is flaky with Python 3.14, so I copied the existing filter warning
    ignore:Exception ignored in. <function IOBase.__del__:pytest.PytestUnraisableExceptionWarning

    and adapted it to the Python 3.14 syntax
  • I don't know why the doc builds are failing; perhaps that is unrelated?

@mr-c mr-c force-pushed the ci/py3.14.0-final branch 3 times, most recently from d2fe6f9 to 8f28fd9 Compare January 8, 2026 11:43
@mr-c mr-c marked this pull request as draft January 8, 2026 11:48
@mr-c mr-c changed the title Mark Python 3.14 as being officially supported. tests: silence a Python 3.14 specific warning; Mark Python 3.14 as being officially supported. Jan 8, 2026
@mr-c mr-c force-pushed the ci/py3.14.0-final branch from 8f28fd9 to 04c6ad1 Compare January 8, 2026 11:56
@mr-c mr-c marked this pull request as ready for review January 8, 2026 11:58
mr-c and others added 2 commits January 8, 2026 13:03
The existing Python 3.13 filterwarning is copied and adapted for the
Python 3.14 syntax
Now that the silence warning issue is fixed.

Fixes: cherrypy#767
@mr-c mr-c force-pushed the ci/py3.14.0-final branch from 04c6ad1 to 372d3e0 Compare January 9, 2026 14:44
@mr-c
Copy link
Author

mr-c commented Jan 9, 2026

Doc failures are fixed in #811 ; I can include those here, if desired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.14 compatibility

1 participant