hslink: Reverse reset level on hw 1.3.x

[kaidegit]

Summary by CodeRabbit

• Bug Fixes
  • Expanded hardware version compatibility to recognize and properly support additional hardware variants. The initialization process now correctly handles a broader range of device configurations, enhancing system compatibility. This update ensures proper operation across more hardware versions, improving overall reliability and user experience on supported devices.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The change modifies the hardware version check in Setting_Init to expand the trigger condition for setting reset_level to 1. Previously, only hardware version (1, 2, 0xFF) qualified; now both (1, 2, 0xFF) and (1, 3, 0xFF) trigger this behavior via an OR condition.

Changes

Cohort / File(s)	Summary
Hardware Version Check Expansion projects/HSLink-Pro/src/setting.cpp	Expanded version check condition in Setting_Init to include additional hardware version (1, 3, 0xFF) alongside existing (1, 2, 0xFF) using short-circuit OR logic

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Verify that version numbers (1, 3, 0xFF) are accurate and intentional
• Confirm the OR condition is correctly implemented
• Cross-reference with related hardware version compatibility requirements

Possibly related PRs

• hslink: support hw 1.3.0 #52: Implements the identical hardware version check expansion, adding (1, 3, 0xFF) support to version guards across the related project.

Suggested reviewers

• HalfSweet

Poem

🐰 Version (1, 2)? Check! Now (1, 3) too?
With OR logic, we've expanded the crew!
Hardware support grows, compatibility thrives,
Reset_level flows through both versions' lives! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: enabling reset level for hardware version 1.3.x in addition to the existing 1.2.x support.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d97fec7 and 6ce43dd.

📒 Files selected for processing (1)

• projects/HSLink-Pro/src/setting.cpp (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

projects/HSLink-Pro/src/setting.cpp (1)

projects/HSLink-Pro/common/hslinkpro/board.c (1)

• CheckHardwareVersion (182-194)

🔇 Additional comments (1)

projects/HSLink-Pro/src/setting.cpp (1)

232-236: reset_level condition correctly extended to cover hw 1.3.x

The new condition cleanly reuses CheckHardwareVersion to treat 1.2.x and 1.3.x boards the same (patch wildcard via 0xFF), and the resulting reset_level assignments remain straightforward and explicit. The change is functionally sound and localized.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[HalfSweet]

LGTM