Aggressive LMTP header cleanup #816
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will remove all headers possible during LMTP delivery. From header: required or clients do not process the message correctly Message-Id header: required for clients to know which messages have been downloaded
feld
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Failure
feld
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Failure
Contributor
|
We should deploy this on ci-chatmail.testrun.org before merging, to run core CI against it. @link2xt do we need to do anything for this other than |
Contributor
|
This will break message previews in the new core because of unencrypted |
Collaborator
Author
|
I don't want to merge this until several core members are very confident this will not break anything. We can just continue iterating and thinking about whether the test coverage we have is sufficient and what the downsides may be as we continue the journey to remove all possible plaintext metadata from relay storage. Does anyone know why we need the "From" header? |
feld
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Error
feld
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove all headers possible during LMTP delivery.
From header: required or clients do not process the message correctly
Message-Id header: required for clients to know which messages have been downloaded