Skip to content

cmdeploy: fail on errors in postfix/dovecot config #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
missytake merged 4 commits into from
Jan 21, 2026
Merged

cmdeploy: fail on errors in postfix/dovecot config #813

missytake merged 4 commits into from
Jan 21, 2026

Conversation

@missytake
Copy link
Contributor

@missytake missytake commented Jan 20, 2026 •
edited
Loading

This should fail CI, at least the commit failed when deployed manually.

When we confirmed that CI fails on broken config, we can fix the dovecot config and merge to main.

@missytake
Copy link
Contributor Author

missytake commented Jan 20, 2026

Fails with:

Jan 20 18:40:43 staging2 systemd[1]: dovecot.service: Scheduled restart job, restart counter is at 17.
Jan 20 18:40:43 staging2 systemd[1]: Stopped dovecot.service - Dovecot IMAP/POP3 email server.
Jan 20 18:40:43 staging2 systemd[1]: Starting dovecot.service - Dovecot IMAP/POP3 email server...
Jan 20 18:40:43 staging2 dovecot[30980]: doveconf: Fatal: Error in configuration file /etc/dovecot/dovecot.conf: event filter: syntax error, unexpected invalid token, expecting '=' or '>' or '<'
Jan 20 18:40:43 staging2 systemd[1]: dovecot.service: Main process exited, code=exited, status=89/n/a
Jan 20 18:40:43 staging2 systemd[1]: dovecot.service: Failed with result 'exit-code'.
Jan 20 18:40:43 staging2 systemd[1]: Failed to start dovecot.service - Dovecot IMAP/POP3 email server.

j4n
j4n reviewed Jan 21, 2026
View reviewed changes
@j4n j4n temporarily deployed to staging-ipv4.testrun.org January 21, 2026 09:06 — with GitHub Actions Inactive
@j4n j4n temporarily deployed to staging-ipv4.testrun.org January 21, 2026 09:32 — with GitHub Actions Inactive
@j4n
Copy link
Contributor

j4n commented Jan 21, 2026

Ok, addressed the syntax error (I sincerely wonder how this slipped through, I suppose it only manifests on a full dovecot restart); and added a config check before restarting so syntax errors don't bring down the service again.

@j4n
Copy link
Contributor

j4n commented Jan 21, 2026

maybe it makes sense to do such a check on postfix as well?

@j4n j4n temporarily deployed to staging2.testrun.org January 21, 2026 09:57 — with GitHub Actions Inactive
@j4n j4n marked this pull request as draft January 21, 2026 10:24
@j4n j4n marked this pull request as ready for review January 21, 2026 10:25
@missytake
Copy link
Contributor Author

missytake commented Jan 21, 2026

maybe it makes sense to do such a check on postfix as well?

trickier, postconf returns exit code 0 on warnings. But I found a way.

@missytake missytake force-pushed the fix-dovecot-metrics-ci branch from aeadae2 to 9e31985 Compare January 21, 2026 10:55
@missytake missytake temporarily deployed to staging-ipv4.testrun.org January 21, 2026 11:24 — with GitHub Actions Inactive
@missytake missytake temporarily deployed to staging2.testrun.org January 21, 2026 11:24 — with GitHub Actions Inactive
@missytake missytake mentioned this pull request Jan 21, 2026
Open
@j4n j4n force-pushed the fix-dovecot-metrics-ci branch from 04a6b01 to 74267b1 Compare January 21, 2026 13:16
@j4n j4n had a problem deploying to staging-ipv4.testrun.org January 21, 2026 13:16 — with GitHub Actions Error
@j4n j4n temporarily deployed to staging2.testrun.org January 21, 2026 13:16 — with GitHub Actions Inactive
missytake
missytake commented Jan 21, 2026
View reviewed changes
cmdeploy/src/cmdeploy/postfix/deployer.py Outdated
if need_restart:
server.shell(
name="Validate postfix configuration",
commands=["postconf -n >/dev/null"],
Copy link
Contributor Author

@missytake missytake Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will not fail on warnings, only fatal errors; e.g. wrong config keys only cause warnings. But that's fine I guess, at least the service will start normally.

@missytake missytake changed the title CI: enable mtail, reapply idle/hibernate metrics cmdeploy: fail on errors in postfix/dovecot config Jan 21, 2026
missytake and others added 3 commits January 21, 2026 15:02
@missytake @j4n
ci: enable mtail for CI
ebb8921 
github deployments: be lenient on the whitespace in sed replace of
mtail_address
@j4n
dovecot.conf: fix the stats syntax
66afe68 
The ! character in != is an invalid token in Dovecot's unified filter
language (2.3.12+). The parser expected a comparison operator (=, >, <)
and choked on !.
@j4n
cmdeploy/{postfix,dovecot}/deployer.py: check config before restarting
5410bb3 
postfix: also fail on warnings
@j4n j4n force-pushed the fix-dovecot-metrics-ci branch from ea128dc to 5410bb3 Compare January 21, 2026 14:04
@j4n j4n temporarily deployed to staging-ipv4.testrun.org January 21, 2026 14:04 — with GitHub Actions Inactive
@j4n j4n temporarily deployed to staging2.testrun.org January 21, 2026 14:04 — with GitHub Actions Inactive
j4n
j4n approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@j4n j4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improved postconf checks (not as nice as doveconf)

@missytake missytake merged commit 2d0ccdb into main Jan 21, 2026
6 checks passed
@missytake missytake deleted the fix-dovecot-metrics-ci branch January 21, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j4n j4n j4n approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@missytake @j4n