Remove the use of globals in implementation #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queries and propagates all of the required function pointers into each struct that needs it, removing the need for a global function/variable to store the loaded vulkan functions. This does require changing the API of the SwapchainBuilder constructor which takes Vulkan handles directly to include the VkInstance, since otherwise it is impossible to load the required functions.
charles-lunarg
force-pushed
the
remove_globals
branch
from
8c3d49e to
865be8d
Compare
Contributor
|
Shouldn't |
Owner
Author
No because that would break all of the function pointers that have been loaded. Vk-bootstrap never bothered to clean up the libvulkan handle before, and because of the nature of the I do admit this isn't ideal and leaking dynamic libraries isn't great, but its the corner I've gotten myself into. |
Contributor
|
What do you think about #442? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries and propagates all of the required function pointers into each struct that needs it, removing the need for a global function/variable to store the loaded vulkan functions.
This does require changing the API of the SwapchainBuilder constructor which takes Vulkan handles directly to include the VkInstance, since otherwise it is impossible to load the required functions.