Open
Conversation
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
smoser
reviewed
Jan 30, 2026
| analyzing APK dependency relationships. | ||
|
|
||
| A package is considered redundant if: | ||
| - It's a transitive dependency of another package in the same list |
Contributor
There was a problem hiding this comment.
hmm... Its better for a package to be explicit on its dependencies.
Given:
- A depends on B and A depends on C
- B depends on C
Are you saying that A does not need to declare its dependency on C?
As example, Consider a package 'whizzy' which invokes curl and ceph. Currently ceph depends on curl, so whizzy could live without a curl dependency. But at some point a new version of ceph might no longer depend on curl. If whizzy does not have a dependency on curl itself, then it will be broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At considerable places we get reviews like go/build pipeline already pulls in go, busybox and we shouldn't be explicit at build time about those deps.
another common reviews is around runtime as well like
bash-binshalready pulls inbashandbash-binshboth so let's not be explicit with both at runtime.sometimes it's hard to get the dependency order in head while you're dealing with big package configs.
trimsubcommand should help us go closer to a perfect fully implicit config.