feat(var-naming): deprecate and gracefully translate skip option#1
Merged
chaimleib merged 2 commits intofix/var-naming/1602-default-golint-behaviorfrom Dec 5, 2025
Conversation
6b7c727 to
c95816a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR mgechev#1603 fixes mgechev#1602, but breaks the
skipPackageNameCollisionWithGoStdoption. This PR gracefully handles the situation and warns the user about the deprecation.Manual testing
All the below tests start from this basic state. Create a folder named
httplike so:http.gorevive.tomlBuild
revive:$ cd path/to/revive $ make buildNavigate to the
httpfolder:$ cd path/to/httpEmpty arguments
$ path/to/revive/revive . $ ls http.go revive.tomlNo errors, just like golint.
Debug mode, empty arguments
The command creates
revive.log. No errors, just INFOs.