This repository was archived by the owner on Dec 3, 2021. It is now read-only.
Open
Conversation
Update disabling functionality to work with or without ngDisabled Update angular dependency to "angular: ~1.4.0" in bower.json
Owner
|
Why do you need to setup the angular dependency to 1.4? I'm pretty sure with this change we lose the ability to install with any angular version under 1.4. |
Author
|
My fix is strictly targeted towards TL;DR This is for a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update disabling functionality to work with or without
ngDisabledUpdate angular dependency to
angular: ~1.4.0in bower.jsonNote that without
ngDisabledbrowser standards are followed. Expressions should not be passed to thedisabledattribute since disabling functionality can be dictated solely by it's presence, ignoring any value.