Conversation
Contributor
Author
|
To be merged together with cs3org/reva#5301 |
jessegeens
force-pushed
the
feat/proj-admin-shares
branch
2 times, most recently
from
114a39a to
6a97f29
Compare
jessegeens
changed the title
jessegeens
added a commit
to cs3org/reva
that referenced
this pull request
Sep 17, 2025
This auto-injected filter was removed in the plugins by cernbox/reva-plugins#51
jessegeens
force-pushed
the
feat/proj-admin-shares
branch
2 times, most recently
from
f5b5dbc to
51a0380
Compare
glpatcern
reviewed
Sep 18, 2025
This is to allow project admins to see all shares on a resource
jessegeens
force-pushed
the
feat/proj-admin-shares
branch
from
51a0380 to
4ebae95
Compare
glpatcern
approved these changes
Sep 19, 2025
Member
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
This is the "easy" part, still have to go through the Reva PR!
glpatcern
pushed a commit
to cs3org/reva
that referenced
this pull request
Sep 24, 2025
* Show shares to project admins Some modifications to the ways shares are listed to allow project admins to view shares * fix unit tests * add user filter to SharedByMe This auto-injected filter was removed in the plugins by cernbox/reva-plugins#51 * Making cache generic * fix infinite loop with mtime When you fetch a storage space, a Stat call happens to the root of the storage space to get the space's mtime. However, to allow project admins to fetch all shares, we would need to set the `.Space` property of a resource info in a Stat, which could lead to an infinite loop. Therefore, this commit only does the fetching of a space when a special value in the opaques is set. To do this efficiently, a space info cache was also added to the StorageProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to show all shares to project admins, we stop injecting a filter for the current user, and rely on calling functions to put a user filter in the request filters